Skip to content

fix: clear virtual text on continue request#92

Merged
theHamsta merged 1 commit intotheHamsta:masterfrom
Dusk-afk:fix/clear_on_continue
May 25, 2025
Merged

fix: clear virtual text on continue request#92
theHamsta merged 1 commit intotheHamsta:masterfrom
Dusk-afk:fix/clear_on_continue

Conversation

@Dusk-afk
Copy link
Copy Markdown
Contributor

@Dusk-afk Dusk-afk commented Jan 6, 2025

This PR fixes a bug where virtual text is not cleared when the debugger is continued through a continue request. The issue arises because the continued event is not emitted for continue requests, as per DAP documentation. To resolve this, a listener for the continue request has been added to ensure the virtual text is cleared as expected.

Copy link
Copy Markdown
Owner

@theHamsta theHamsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thank you! Sorry, for not seeing this for such a long time!

@theHamsta theHamsta enabled auto-merge (rebase) May 25, 2025 14:00
@theHamsta theHamsta closed this May 25, 2025
auto-merge was automatically disabled May 25, 2025 14:00

Pull request was closed

@theHamsta theHamsta reopened this May 25, 2025
@theHamsta theHamsta merged commit 0f0b9b1 into theHamsta:master May 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants